deps: update temporal_rs to 0.2.3 - #64543
Closed
Renegade334 wants to merge 3 commits into
Closed
Conversation
Original commit message:
Update DEPS for ICU4X/temporal_rs changes
Change-Id: I22328bcc0f50e3dd0aa955021d090f466a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7727682
Auto-Submit: Manish Goregaokar <manishearth@google.com>
Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106257}
Refs: v8/v8@7d9b7e0
Renegade334
added
commit-queue-rebase
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
Renegade334
force-pushed
the
temporal-0.2.3
branch
from
July 16, 2026 19:16
6d1d58d to
4d2613d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Renegade334
marked this pull request as ready for review
July 22, 2026 12:26
targos
reviewed
Jul 22, 2026
targos
reviewed
Jul 22, 2026
targos
approved these changes
Jul 22, 2026
legendecas
approved these changes
Jul 22, 2026
Member
|
AIX status is pending but the CI is over and green. |
Member
|
Any blockers? |
Member
Author
|
Figured I'd let it bake for a bit longer as a large PR, but all the requirements are met so may as well get this merged. |
Renegade334
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 58795e9...ea48ad3 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 27, 2026
Original commit message:
Update DEPS for ICU4X/temporal_rs changes
Change-Id: I22328bcc0f50e3dd0aa955021d090f466a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7727682
Auto-Submit: Manish Goregaokar <manishearth@google.com>
Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106257}
Refs: v8/v8@7d9b7e0
PR-URL: #64543
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jul 27, 2026
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #64543 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates temporal_rs via a standalone run of the crates updater from nodejs/node-core-utils#1117. As mentioned previously, temporal_rs 0.2 contains a bunch of fixes for bugs and spec compliance issues (boa-dev/temporal@v0.1.2...v0.2.3) which means we should really upgrade before v26 goes LTS.
deps: V8: backport 7d9b7e03141d
Updates to the
third_party/rustdependency of V8 14.9.6, which corresponds to temporal_rs 0.2.3.deps: update Rust crates for V8 14.6.202.34-node.26
There is an additional 20MiB checked into the
deps/crates/vendordirectory as a result of the dependency changes. Most of this is locale data and ICU4X tests, which doesn't get compiled into the rust build; the final Node.js binary size is only around 10KiB larger.build: bump rustc requirement to >=1.86
Updates BUILDING.md and the GHA workflows.